Conversation
spec.md
Outdated
| and `VERSION` (which version of the vCard standard you're using), | ||
| and if available it SHOULD contain `FN` (display name), | ||
| `PHOTO` (avatar), | ||
| `KEY` (public key), and |
There was a problem hiding this comment.
could you say in which format the key must be?
There was a problem hiding this comment.
It's in base64, in our case we obtain it by calling to_base64() on the pgp crate's SignedPublicKey. Is there a way to further specify the key format than saying it's base64?
There was a problem hiding this comment.
I can't find a to_base64 in SignedPublicKey. Can you help me understand what function is used in the conversion?
And/or: Does the format look different from normal "ASCII Armored" OpenPGP keys?
There was a problem hiding this comment.
I can't find a
to_base64in SignedPublicKey. Can you help me understand what function is used in the conversion?
It's implemented by the deltachat::key::DcKey trait.
There was a problem hiding this comment.
Thanks! So it's this code.
The code takes the SignedPublicKey, and serialized it as a "binary" OpenPGP object (not ASCII Armored), and then base64 encodes that.
I don't know what the best language is, for the spec.md documentation. But I'd suggest something along the lines: "An OpenPGP public key, in binary format, encoded with vanilla base64 (note that this is different from the OpenPGP 'ASCII Armor' format)".
There was a problem hiding this comment.
I updated the PR, thanks!
I also checked that the key in the vCard created by protonmail can be imported successfully. So, apparently we're doing everything correctly 👍 (and it's correct that we're not using ASCII Armor - while I had heard about it, I neither had it on my radar nor did I know that it's different from what we're doing)
hpk42
left a comment
There was a problem hiding this comment.
other than the comment this looks fine.
It's only a rough spec like the rest so it's consistent ;)
spec.md
Outdated
| and `VERSION` (which version of the vCard standard you're using), | ||
| and if available it SHOULD contain `FN` (display name), | ||
| `PHOTO` (avatar), | ||
| `KEY` (public key), and |
There was a problem hiding this comment.
I can't find a
to_base64in SignedPublicKey. Can you help me understand what function is used in the conversion?
It's implemented by the deltachat::key::DcKey trait.
Also, move the
Miscellaneoussection to the end again and update the table of contents with https://derlin.github.io/bitdowntoc/.