chore: update provider database #5966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes OAuth2 for Gmail as Delta Chat does not have a working client ID anymore. Tests are adjusted to test against Yandex and MX queries for OAuth2 are always disabled because they were only used to detect Google Workspace.
link2xt
force-pushed
the
link2xt/update-provider-database
branch
from
f6b3b67 to
2e151b4
Compare
Collaborator
Author
|
See chatmail/provider-db#310 for the change to the provider database that disabled Gmail. |
iequidoo
approved these changes
Sep 13, 2024
| async fn from_address(context: &Context, addr: &str, skip_mx: bool) -> Option<Self> { | ||
| async fn from_address(context: &Context, addr: &str) -> Option<Self> { | ||
| let addr_normalized = normalize_addr(addr); | ||
| let skip_mx = true; |
Collaborator
There was a problem hiding this comment.
Sure MX lookup will be never needed for yandex?
Collaborator
Author
There was a problem hiding this comment.
If we support it, we can enable it and test. I think Yandex has something like Google Workspace already but doubt we want to support it, especially since Yandex is unusable anyway due to strict rate limits and requests to solve captcha on the web when you hit the limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes OAuth2 for Gmail
as Delta Chat does not have a working
client ID anymore.
Tests are adjusted to test against Yandex
and MX queries for OAuth2 are always disabled
because they were only used to detect Google Workspace.