Conversation
r10s
force-pushed
the
r10s/internal-profile-names
branch
from
8d5e085 to
90d26e3
Compare
adbenitez
approved these changes
Oct 21, 2024
Collaborator
adbenitez
left a comment
adbenitez
left a comment
There was a problem hiding this comment.
nice, yeah synchronizing this config across devices makes a lot of sense so it is a good step forward to have it as core config instead of ui.*
r10s
force-pushed
the
r10s/internal-profile-names
branch
from
90d26e3 to
ba31c52
Compare
r10s
force-pushed
the
r10s/internal-profile-names
branch
from
ba31c52 to
7374831
Compare
link2xt
approved these changes
Oct 22, 2024
Collaborator
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
Commit or PR (if you squash-merge) should have a prefix like feat or api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows setting a "private tag" for a profile, see deltachat/deltachat-android#3373 for a possible UI.
currently, the core does not do anything with the tag (so, it could also be a ui.-config option), however, this may change in the future - it might bet synced, and become also otherwise useful in core. also, having this in core is better documentation-wise, as otherwise each UI easily does its own things :)