Skip to content

Add getWebxdcHref to json api#6281

Merged
nicodh merged 3 commits intomainfrom
get-webxdc-href-in-jsonrpc
Dec 2, 2024
Merged

Add getWebxdcHref to json api#6281
nicodh merged 3 commits intomainfrom
get-webxdc-href-in-jsonrpc

Conversation

@nicodh
Copy link
Copy Markdown
Contributor

@nicodh nicodh commented Nov 30, 2024

No description provided.

@nicodh nicodh requested a review from r10s November 30, 2024 15:44
@nicodh nicodh force-pushed the get-webxdc-href-in-jsonrpc branch from 1fef259 to 73a0371 Compare November 30, 2024 15:58
Copy link
Copy Markdown
Contributor

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test, but looks good :)
and if it compiles, it's perfect :)

@nicodh
Copy link
Copy Markdown
Contributor Author

nicodh commented Nov 30, 2024

I tested it with deltachta-desktop

@nicodh nicodh requested a review from Simon-Laux December 1, 2024 09:37
webxdc_info,

// On a WebxdcInfoMessage this might include a hash holding
// information about a specific position or state in a webxdc app
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// information about a specific position or state in a webxdc app
// information about a specific position or state in the Webxdc app.

@nicodh nicodh merged commit 3ad9cf3 into main Dec 2, 2024
@nicodh nicodh deleted the get-webxdc-href-in-jsonrpc branch December 2, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants