fix: Fix order of operations when handling "vc-request-with-auth"#6850
Merged
fix: Fix order of operations when handling "vc-request-with-auth"#6850
Conversation
link2xt
reviewed
May 12, 2025
link2xt
reviewed
May 12, 2025
|
|
||
| // Bob should already have Alice's key | ||
| // so that he can directly send vc-request-with-auth | ||
| tcm.send_recv(alice, bob, "hi").await; |
Collaborator
There was a problem hiding this comment.
You don't need to send any messages, just import a vCard with add_or_lookup_contact_id.
Collaborator
Author
There was a problem hiding this comment.
Importing a vCard only sets gossiped key, and bob::start_protocol()->verify_sender_by_fingerprint() only looks at the public_key_fingerprint. So, the test would fail. With PGP contacts, it would be enough to call bob.create_chat(alice)
link2xt
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.