Skip to content

build: add nodejs to nix dev env#7283

Merged
Simon-Laux merged 1 commit intomainfrom
simon/add-node-to-nix-dev-env
Oct 9, 2025
Merged

build: add nodejs to nix dev env#7283
Simon-Laux merged 1 commit intomainfrom
simon/add-node-to-nix-dev-env

Conversation

@Simon-Laux
Copy link
Copy Markdown
Member

it is required to build jsonrpc client npm package and for the stdio
server npm package

it is required to build jsonrpc client npm package and for the stdio
server npm package
@Simon-Laux Simon-Laux requested review from Septias and link2xt October 8, 2025 11:34
Copy link
Copy Markdown
Collaborator

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add build or something to commit (or PR if you squash-merge) so git-cliff does not copy the whole message to changelog into "other" section.

@Simon-Laux Simon-Laux changed the title add nodejs to nix dev env build: add nodejs to nix dev env Oct 9, 2025
@Simon-Laux Simon-Laux merged commit 00ae7ce into main Oct 9, 2025
67 checks passed
@Simon-Laux Simon-Laux deleted the simon/add-node-to-nix-dev-env branch October 9, 2025 14:27
@link2xt
Copy link
Copy Markdown
Collaborator

link2xt commented Oct 9, 2025

Well, this does not work if you don't squash-merge, now main has 00ae7ce without the build prefix and this is what git-cliff looks at.

@Simon-Laux
Copy link
Copy Markdown
Member Author

Well, this does not work if you don't squash-merge

sorry wasn't paying enough attention when clicking the button, I thought it showed squash, but looks like I miss-clicked.,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants