fix: add device message instead of partial message when receive_imf fails #7401
Conversation
link2xt
force-pushed
the
link2xt/xlkmqompqlss
branch
2 times, most recently
from
5660333 to
e85b131
Compare
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
Would be good if such messages could be received later after fixing the problem, i think this will usually happen when an outdated version is used. Are there any ideas about this? Maybe we can at least remember the first failed message UID in the imap_sync table so that we can retry later?
src/imap.rs
Outdated
| warn!(context, "receive_imf error: {err:#}."); | ||
|
|
||
| let text = format!( | ||
| "There was an error receiving some message. Please report this bug to developers. The error message is: {err:#}." |
There was a problem hiding this comment.
| "There was an error receiving some message. Please report this bug to developers. The error message is: {err:#}." | |
| "There was an error receiving some message. Please report this bug to delta@merlinux.eu or https://support.delta.chat/. The error message is: {err:#}." |
|
may these errors been triggered when as that is a quite common case (even if premessage will mitigate things a lot, it can happen on slow network, eg. not sure if core can respect the timeout given in all cases) - so wondering if we retry messages failing in background once in the normal forgroud loop - only if that fails as well, we write a device message if that makes sense, we should create a separate issue, however. this PR is fine as is to move forward. goal is that the user does not see the message at all on normal usage (i have seen the old partial download here and then since it was introduces not so long ago) |
No, this can only happen if |
link2xt
force-pushed
the
link2xt/xlkmqompqlss
branch
3 times, most recently
from
69d82c5 to
ac76ad2
Compare
link2xt
force-pushed
the
link2xt/xlkmqompqlss
branch
from
ac76ad2 to
c725e66
Compare
|
The problem is that the user will never see failed messages even after updating Delta Chat if it was a compatibility issue. The stuck IMAP loop may be even better in this sense. Are we going to do smth with this? Compatibility testing is complicated and there always will be users not updating on time. EDIT: Maybe the device message should be suggesting updating Delta Chat and restoring a recent backup if the user has any. |
Closes #7321