Skip to content

Conversation

@iequidoo
Copy link
Collaborator

@iequidoo iequidoo commented Nov 8, 2025

Follow-up to #7399 (see #7399 (comment)), otherwise the info message may not be visible enough

@link2xt link2xt requested a review from Hocuri November 8, 2025 17:28
@iequidoo iequidoo merged commit fdea6c8 into main Nov 8, 2025
28 of 29 checks passed
@iequidoo iequidoo deleted the iequidoo/sj-qr-for-old-broadcast branch November 8, 2025 19:23
@Hocuri
Copy link
Collaborator

Hocuri commented Nov 10, 2025

Thanks for following up!

At least on Android, the QR code isn't actually shown unfortunately - probably it was decided that error!() is being used too frequently, and that the error toasts do more harm than good.

We should at some point in the future discuss about that discrepancy between core expectations and UI behavior - maybe the UI can just start showing toasts again, or maybe it helps to create a new macro show_error_toast!() with a corresponding event. Not right now, probably, there are a lot of discussions already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants