Skip to content

fix: set get_max_smtp_rcpt_to for chatmail to the actual limit of 1000 instead of unlimited.#7432

Merged
Simon-Laux merged 3 commits intomainfrom
simon/set-max-smtp-rcpt-to-1000
Nov 13, 2025
Merged

fix: set get_max_smtp_rcpt_to for chatmail to the actual limit of 1000 instead of unlimited.#7432
Simon-Laux merged 3 commits intomainfrom
simon/set-max-smtp-rcpt-to-1000

Conversation

@Simon-Laux
Copy link
Copy Markdown
Member

adb brought this up in an internal discussion.
With the recent introduction of channels it becomes easier to hit the limit
and it becomes impossible to send messages to a channel with more than 1000 members, this pr fixes that.

@Simon-Laux Simon-Laux added the bug Something is not working label Nov 12, 2025
@Simon-Laux Simon-Laux requested a review from adbenitez November 12, 2025 15:54
@Simon-Laux Simon-Laux requested a review from iequidoo November 12, 2025 18:16
@r10s
Copy link
Copy Markdown
Contributor

r10s commented Nov 12, 2025

including or excluding SELF? always guaranteed also on future changes? to play safe, and as i would not trust my code myself wrt off-by-one, i would have used 999 :)

just saying, a bit joking :) the PR is probably fine, maybe there is a test for the 50, at least it happens more often, so one would notice off-by-one already in larger groups

and having an explicit limit rather than implicit is in any case an improvement

thanks for taking care❤️

@iequidoo
Copy link
Copy Markdown
Collaborator

Everything is fine, the code calling get_max_smtp_rcpt_to() runs already after applying the BccSelf logic

Co-authored-by: Hocuri <hocuri@gmx.de>
@Simon-Laux Simon-Laux enabled auto-merge (squash) November 13, 2025 18:25
@Simon-Laux Simon-Laux merged commit dc4ea18 into main Nov 13, 2025
29 checks passed
@Simon-Laux Simon-Laux deleted the simon/set-max-smtp-rcpt-to-1000 branch November 13, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is not working chatmail

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants