Skip to content

Conversation

@Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Nov 20, 2025

Add a stock string %1$s invited you to join this channel.\n\nWaiting for the device of %2$s to reply…, which is shown when a user starts to join a channel.

I did not add an equivalent to %1$s replied, waiting for being added to the group…, which is shown when vg-auth-required was received. I don't think that this would add any information that's interesting to the user, other than 'something is happening, hang on'. And the more text on the screen, the less likely that anyone reads it. But if others think differently, we can also add it.

With this PR, joining a channel looks like this:

Msg#2003: info (Contact#Contact#Info): Messages are end-to-end encrypted. [NOTICED][INFO]
Msg#2004: info (Contact#Contact#Info): Alice invited you to join this channel.

Waiting for the device of Alice to reply… [NOTICED][INFO]
Msg#2007🔒:  (Contact#Contact#2001): You joined the channel. [FRESH][INFO]

@Hocuri Hocuri force-pushed the hoc/stock-str-for-channel-joining branch from a111574 to dedb043 Compare November 20, 2025 16:19
Copy link
Contributor

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r10s
Copy link
Contributor

r10s commented Nov 20, 2025

I did not add an equivalent to %1$s replied, waiting for being added to the group…, which is shown when vg-auth-required was received. I don't think that this would add any information that's interesting to the user, other than 'something is happening, hang on'

agree. that came a bit from the time where things were much slower.

if things are not needed for channels at the end, maybe we can remove that part also for the group join

@Hocuri Hocuri force-pushed the hoc/stock-str-for-channel-joining branch from dedb043 to 782708a Compare November 20, 2025 21:01
@Hocuri Hocuri enabled auto-merge (squash) November 20, 2025 21:02
@Hocuri Hocuri merged commit 2f90b55 into main Nov 20, 2025
29 checks passed
@Hocuri Hocuri deleted the hoc/stock-str-for-channel-joining branch November 20, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants