Prepare for transport sync #7530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/transport-sync-prepare
branch
from
759f4ba to
e6a2d94
Compare
Currently there is a race between transports to upload sync messages and delete them from `imap_send` table. Sometimes mulitple transports upload the same message and sometimes only some of them "win". With this change only the primary transport will upload the sync message.
link2xt
force-pushed
the
link2xt/transport-sync-prepare
branch
from
e6a2d94 to
4fa2153
Compare
Simon-Laux
approved these changes
Nov 28, 2025
hpk42
reviewed
Nov 28, 2025
| .get_config(Config::ConfiguredAddr) | ||
| .await? | ||
| .unwrap_or_default() | ||
| == connection.addr |
Contributor
There was a problem hiding this comment.
just a side question: should this better be something like has_transport_address(connection.addr) in the multi-transport feature? "ConfiguredAddr" does not feel like a valid thing to work with anymore.
Collaborator
Author
There was a problem hiding this comment.
configured_addr is the address of the primary transport. Unlike all other configured_* settings it is not deprecated and is used to set the primary transport and tell which transport is currently the primary one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #7485, I have split easier to review changes here so it can be merged quickly.