-
-
Notifications
You must be signed in to change notification settings - Fork 114
Fix Python CI #7538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix Python CI #7538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
350357f to
c8fc344
Compare
Python 3.9 is not supported since 2025-10-31: https://devguide.python.org/versions/ mypy just dropped support for Python 3.9: <python/mypy@1a6ff59>
License classifiers are replaced with `license`. This is supported since `setuptools` v77.0.0: <https://setuptools.pypa.io/en/stable/history.html#v77-0-0> Without this change we get `SetuptoolsDeprecationWarning: License classifiers are deprecated.` with a reference to <https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license>
c8fc344 to
52e28e0
Compare
link2xt
commented
Nov 28, 2025
| # built. Test it with minimum supported Rust version. | ||
| - os: ubuntu-latest | ||
| python: 3.8 | ||
| python: "3.10" |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to YAML, 3.10 is parsed as 3.1, so now this needs to be quoted.
mypy depends on librt since 1.19.0 and it fails to build with PyPy 3.10.
74807cf to
0b26378
Compare
This was referenced Nov 28, 2025
hpk42
approved these changes
Nov 28, 2025
Contributor
hpk42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three changes:
licensefield and require setuptools 77 which supports it. This avoids deprecation warnings.