Skip to content

Conversation

@link2xt
Copy link
Collaborator

@link2xt link2xt commented Nov 28, 2025

Three changes:

  1. Increase minimum supported Python version to 3.10. Python 3.9 is not supported anymore according to https://devguide.python.org/versions/ and mypy just dropped support for it. mypy dropping support is not really a problem because we can still use old mypy, just noticed that they also drop support for unsupported python.
  2. Use license field and require setuptools 77 which supports it. This avoids deprecation warnings.
  3. Pin mypy to 1.18.2 as 1.19 which was just released broke PyPy 3.10 CI runs: 1.19 Release Planning python/mypy#19964 (comment)

@link2xt link2xt marked this pull request as draft November 28, 2025 20:49
@link2xt link2xt force-pushed the link2xt/pyproject-license branch from 350357f to c8fc344 Compare November 28, 2025 20:58
@link2xt link2xt changed the title build: use SPDX license expression in Python package metadata Fix Python builds Nov 28, 2025
Python 3.9 is not supported since 2025-10-31:
https://devguide.python.org/versions/

mypy just dropped support for Python 3.9:
<python/mypy@1a6ff59>
License classifiers are replaced with `license`.
This is supported since `setuptools` v77.0.0:
<https://setuptools.pypa.io/en/stable/history.html#v77-0-0>

Without this change we get
`SetuptoolsDeprecationWarning: License classifiers are deprecated.`
with a reference to
<https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license>
@link2xt link2xt force-pushed the link2xt/pyproject-license branch from c8fc344 to 52e28e0 Compare November 28, 2025 21:09
# built. Test it with minimum supported Rust version.
- os: ubuntu-latest
python: 3.8
python: "3.10"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to YAML, 3.10 is parsed as 3.1, so now this needs to be quoted.

mypy depends on librt since 1.19.0
and it fails to build with PyPy 3.10.
@link2xt link2xt force-pushed the link2xt/pyproject-license branch from 74807cf to 0b26378 Compare November 28, 2025 21:29
@link2xt link2xt changed the title Fix Python builds Fix Python CI Nov 28, 2025
@link2xt link2xt marked this pull request as ready for review November 28, 2025 21:53
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@link2xt link2xt merged commit 721b9ce into main Nov 28, 2025
29 checks passed
@link2xt link2xt deleted the link2xt/pyproject-license branch November 28, 2025 22:14
@link2xt link2xt mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants