feat(pgp): use preferred hash algorithm for signing instead of hardcoded SHA256#7731
Merged
feat(pgp): use preferred hash algorithm for signing instead of hardcoded SHA256#7731
Conversation
…ded SHA256 There is no difference for RSA and Ed25519, the only signing keys that we generate. The both use SHA256: <https://github.com/rpgp/rpgp/blob/7e3b6c0af21e4a45c2a2dcba67f0b649e0b6e456/src/types/params/public.rs#L231-L234> The only difference is for the possible future PQC signing keys and imported NIST P-512 and NIST P-384 keys.
Simon-Laux
approved these changes
Jan 15, 2026
iequidoo
approved these changes
Jan 18, 2026
Collaborator
Author
|
This will make it possible to import P-521 keys: https://support.delta.chat/t/could-you-please-comment-on-this-deltachat-message/4617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no difference for RSA and Ed25519,
the only signing keys that we generate.
The both use SHA256:
https://github.com/rpgp/rpgp/blob/7e3b6c0af21e4a45c2a2dcba67f0b649e0b6e456/src/types/params/public.rs#L231-L234
The only difference is for the possible future PQC signing keys and imported NIST P-512 and NIST P-384 keys.