docs(RELEASE.md): add section about dealing with antivirus false positives#7855
Merged
docs(RELEASE.md): add section about dealing with antivirus false positives#7855
Conversation
6e3fe5d to
f43a21b
Compare
a83031c to
784d6cb
Compare
Hocuri
approved these changes
Feb 23, 2026
RELEASE.md
Outdated
|
|
||
| 9. Create a GitHub release: `gh release create v1.116.0 --notes ''`. | ||
|
|
||
| 10. Once the binaries are generated and published, check Windows binaries for false positive detections at [VirusTotal]. Either upload the binaries directly or submit a direct link to the artifact. You can use [old browsers interface](https://www.virustotal.com/old-browsers/) if there are problems with using the default website. If you submit a direct link and get to the page saying "No security vendors flagged this URL as malicious", it does not mean that the file itself is not detected. You need to go to the "details" tab and click on the SHA-256 hash in the "Body SHA-256" section. If any false positive is detected, open an issue to track removing it. See <https://github.com/chatmail/core/issues/7847> for an example of false positive detection issue. If there is a false positive "Microsoft" detection, mark the issue as a blocker. |
Collaborator
There was a problem hiding this comment.
We should explain where to get the binaries from
Suggested change
| 10. Once the binaries are generated and published, check Windows binaries for false positive detections at [VirusTotal]. Either upload the binaries directly or submit a direct link to the artifact. You can use [old browsers interface](https://www.virustotal.com/old-browsers/) if there are problems with using the default website. If you submit a direct link and get to the page saying "No security vendors flagged this URL as malicious", it does not mean that the file itself is not detected. You need to go to the "details" tab and click on the SHA-256 hash in the "Body SHA-256" section. If any false positive is detected, open an issue to track removing it. See <https://github.com/chatmail/core/issues/7847> for an example of false positive detection issue. If there is a false positive "Microsoft" detection, mark the issue as a blocker. | |
| 10. Once the binaries are [generated](https://github.com/chatmail/core/actions) and [published](https://github.com/chatmail/core/releases), check Windows binaries for false positive detections at [VirusTotal]. Either upload the binaries directly or submit a direct link to the artifact. You can use [old browsers interface](https://www.virustotal.com/old-browsers/) if there are problems with using the default website. If you submit a direct link and get to the page saying "No security vendors flagged this URL as malicious", it does not mean that the file itself is not detected. You need to go to the "details" tab and click on the SHA-256 hash in the "Body SHA-256" section. If any false positive is detected, open an issue to track removing it. See <https://github.com/chatmail/core/issues/7847> for an example of false positive detection issue. If there is a false positive "Microsoft" detection, mark the issue as a blocker. |
Collaborator
Author
There was a problem hiding this comment.
I added the second link, there is no need to get artifacts from actions.
784d6cb to
6bbb684
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.