feat: add backup versions to the importing error message#7864
Merged
Conversation
Hocuri
reviewed
Feb 17, 2026
src/imex.rs
Outdated
| ensure!( | ||
| version <= DCBACKUP_VERSION, | ||
| "Backup too new, please update Delta Chat" | ||
| "Backup version {version} is too new, the latest supported is {DCBACKUP_VERSION}, please update the application" |
Collaborator
There was a problem hiding this comment.
I don't think we should replace "Delta Chat" with "the application" here. Grepping for "delta" in all *.rs files yields 734 results, which will need a dedicated effort to replace (and a stock string for the application name). Replacing it in some places will just make this harder, and calling it "the application" is probably confusing.
In order to clearly tell the user what's the problem and what they should do:
Suggested change
| "Backup version {version} is too new, the latest supported is {DCBACKUP_VERSION}, please update the application" | |
| "This profile is from a newer version of Delta Chat. | |
| Please update Delta Chat and try again. | |
| (Profile version: v{version}; supported: v{DCBACKUP_VERSION})" |
This would have helped debugging the problem reported at <https://support.delta.chat/t/backup-too-new-please-update-delta-chat-message/4761>
link2xt
force-pushed
the
link2xt/rytkvqslzmlv
branch
from
d528168 to
bf59e2a
Compare
Hocuri
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would have helped debugging the problem reported at https://support.delta.chat/t/backup-too-new-please-update-delta-chat-message/4761