fix: Don't fall into infinite loop if the folder is missing#8021
Merged
fix: Don't fall into infinite loop if the folder is missing#8021
Conversation
Hocuri
force-pushed
the
hoc/dont-go-into-infinite-loop-with-missing-folder
branch
from
776c844 to
45c714c
Compare
iequidoo
approved these changes
Mar 23, 2026
Collaborator
|
The bug fixed here is likely the result of #7783, previously we would have created the folder back eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the mvbox_move folder is missing, then core will loop infinitely, because
new_mailis never set to false.The fix is to first set
new_mailto false, then return if the folder is missing.This is the bug @hpk42 experienced when commenting in #7989