Closed
Conversation
r10s
force-pushed
the
r10s/webxdc-sendingcontext
branch
2 times, most recently
from
81c1704 to
e98e87d
Compare
r10s
force-pushed
the
r10s/webxdc-sendingcontext
branch
2 times, most recently
from
e42b492 to
99b24f3
Compare
r10s
force-pushed
the
r10s/webxdc-sendingcontext
branch
from
99b24f3 to
2ed60da
Compare
r10s
force-pushed
the
r10s/webxdc-sendingcontext
branch
from
2ed60da to
c8c33fb
Compare
Amzd
requested changes
Apr 18, 2026
Comment on lines
+4239
to
+4240
| * - can_only_send_updates_to_app_sender: true if updates sent by the local user | ||
| * will only be seen by the app sender. |
Collaborator
There was a problem hiding this comment.
the spec says when this is true the update sender also sees their own updates, not just the app sender
Contributor
Author
There was a problem hiding this comment.
yeah, that question pop up for me as well, see spec. we should be more explicit on that
Comment on lines
+42
to
+43
| /// True if updates sent by the local user | ||
| /// will only be seen by the app sender. |
Contributor
Author
|
superseded by #8138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds sending context to webxdc as discussed at webxdc/website#136
drafting was done with help of llm, this version is adapted and reviewed by hand
performance: this results in two additional database calls for each call to
get_webxdc_info(), as we need to load Chat::typ, and sender's Contact::fingerprint. however,get_webxdc_info()is usually not called on each update, but only on instantiating. already before,get_webxdc_info()does quite some stuff as looking into the zip file, so these additional calls are probably fine and do not add much