Skip to content

api: jsonrpc: remove unused set_draft_vcard()#8161

Merged
r10s merged 1 commit intomainfrom
r10s/remove-vcard
Apr 28, 2026
Merged

api: jsonrpc: remove unused set_draft_vcard()#8161
r10s merged 1 commit intomainfrom
r10s/remove-vcard

Conversation

@r10s
Copy link
Copy Markdown
Contributor

@r10s r10s commented Apr 23, 2026

this PR removes the unused set_draft_vcard() jsonrpc api, see comment at #7960

closes #7960

cc @nicodh - maybe also remove the comment in desktop about why set_draft_vcard is not working

@r10s r10s requested a review from nicodh April 23, 2026 23:57
Copy link
Copy Markdown
Collaborator

@iequidoo iequidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, was added in 889b947, but w/o any test, only a test on Core's internals exists

@r10s r10s merged commit 804590c into main Apr 28, 2026
31 checks passed
@r10s r10s deleted the r10s/remove-vcard branch April 28, 2026 15:12
@r10s
Copy link
Copy Markdown
Contributor Author

r10s commented Apr 28, 2026

PR to remove the stale comment on desktop: deltachat/deltachat-desktop#6311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

problems with RPC API

4 participants