Skip to content

feat: adapt quota warning to automatic cleanup#8168

Merged
r10s merged 1 commit into
mainfrom
r10s/simplify-quota-warning
Apr 25, 2026
Merged

feat: adapt quota warning to automatic cleanup#8168
r10s merged 1 commit into
mainfrom
r10s/simplify-quota-warning

Conversation

@r10s
Copy link
Copy Markdown
Contributor

@r10s r10s commented Apr 24, 2026

with chatmail/relay#929 merged, relay usage should not exceed 80%, to not warn about jittering around that value, this PR removes the device messages for that. also as they're not actionable in the vast majority of cases.

what's left is the info in the connectivity view, for now, for debug and information purposes.

for another PR: there is also the idea to run the client-side-deletion from #8105 automatically at 95% for chatmail. this will be useful esp. for madmail or older relays that do not get automatic quota management. in contrast to server-side-deletion, client-side-deletion is less risky as the messages are usually downloaded on at least one device.

@ell1e
Copy link
Copy Markdown

ell1e commented Apr 24, 2026

I wonder, would it make sense to have some sort of chatmail protocol extension for DeltaChat-specific server capabilities? And/or to differentiate this behavior based on classic email login vs chatmail login?

Basically, I think for custom login SMTP servers, I can see the warning possibly remaining useful in the longer term future - at least the 95% one, that is.

(Sorry if this comment of mine isn't helpful, feel free to ignore it! Just something that came to mind when I saw this.)

@r10s r10s marked this pull request as draft April 24, 2026 23:29
@r10s r10s force-pushed the r10s/simplify-quota-warning branch 2 times, most recently from eb98f1a to 7b19171 Compare April 24, 2026 23:42
@link2xt
Copy link
Copy Markdown
Collaborator

link2xt commented Apr 24, 2026

There is a related issue: #7635

Comment thread src/config.rs
/// If a warning about exceeding quota was shown recently,
/// this is the percentage of quota at the time the warning was given.
/// Unset, when quota falls below minimal warning threshold again.
QuotaExceeding,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was likely even broken with multi-relay, this should be per-transport.

@r10s r10s marked this pull request as ready for review April 24, 2026 23:54
@r10s r10s force-pushed the r10s/simplify-quota-warning branch from 7b19171 to 81f7e27 Compare April 24, 2026 23:58
@r10s r10s merged commit 7de58f5 into main Apr 25, 2026
31 checks passed
@r10s r10s deleted the r10s/simplify-quota-warning branch April 25, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants