feat: adapt quota warning to automatic cleanup#8168
Merged
Conversation
This was referenced Apr 24, 2026
|
I wonder, would it make sense to have some sort of chatmail protocol extension for DeltaChat-specific server capabilities? And/or to differentiate this behavior based on classic email login vs chatmail login? Basically, I think for custom login SMTP servers, I can see the warning possibly remaining useful in the longer term future - at least the 95% one, that is. (Sorry if this comment of mine isn't helpful, feel free to ignore it! Just something that came to mind when I saw this.) |
eb98f1a to
7b19171
Compare
Collaborator
|
There is a related issue: #7635 |
link2xt
reviewed
Apr 24, 2026
| /// If a warning about exceeding quota was shown recently, | ||
| /// this is the percentage of quota at the time the warning was given. | ||
| /// Unset, when quota falls below minimal warning threshold again. | ||
| QuotaExceeding, |
Collaborator
There was a problem hiding this comment.
This was likely even broken with multi-relay, this should be per-transport.
7b19171 to
81f7e27
Compare
link2xt
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with chatmail/relay#929 merged, relay usage should not exceed 80%, to not warn about jittering around that value, this PR removes the device messages for that. also as they're not actionable in the vast majority of cases.
what's left is the info in the connectivity view, for now, for debug and information purposes.
for another PR: there is also the idea to run the client-side-deletion from #8105 automatically at 95% for chatmail. this will be useful esp. for madmail or older relays that do not get automatic quota management. in contrast to server-side-deletion, client-side-deletion is less risky as the messages are usually downloaded on at least one device.