Skip to content

Add option to force encryption#8220

Draft
link2xt wants to merge 3 commits into
link2xt/remove-timesmearingfrom
link2xt/process-unencrypted
Draft

Add option to force encryption#8220
link2xt wants to merge 3 commits into
link2xt/remove-timesmearingfrom
link2xt/process-unencrypted

Conversation

@link2xt
Copy link
Copy Markdown
Collaborator

@link2xt link2xt commented May 7, 2026

Closes #7494

Based on #8226

@link2xt link2xt force-pushed the link2xt/process-unencrypted branch 8 times, most recently from 8914248 to f1652d4 Compare May 12, 2026 12:50
@r10s
Copy link
Copy Markdown
Contributor

r10s commented May 12, 2026

there are lots of discussions preventing to unblock this issue. i try to sum up the outcome, even tho i was not part of the most recent ones:

  1. process_unencrypted should be per relay, not per profile
  2. process_unencrypted is set to true for existing relays (maybe based on old show_emails) - gist is that nothing changes for them
  3. for new relays, it will be false
  4. several relays can have the option set independently, it is up to the user, to deal with the situation
  5. the option will be hidden in "advanced / relay", UI-wise, it should not be worded as a feature ppl would enable without knowing much about it
  6. as we cannot rely on process_unencrypted for "New Email" (otherwise, all existing profiles will get the option because of 2.) - we continue using is_chatmail for that for now

the last point, 6. still looks a bit tricky to me - i do not see a way to get rid of is_chatmail if we set process_unencrypted to true mostly unconditionally. maybe process_unencrypted at 2. should be set depending on existing is_chatmail. but i also was not part of all discussions, maybe this is clear already, then please comment. also correct the list above as needed :)

ftr, "New Email" is the only remaining function that relies on is_chatmail

@link2xt
Copy link
Copy Markdown
Collaborator Author

link2xt commented May 12, 2026

as we cannot rely on process_unencrypted for "New Email" (otherwise, all existing profiles will get the option because of 2.) - we continue using is_chatmail for that for now

We can turn "process unencrypted" off for relays that advertise XCHATMAIL automatically. And UIs can then show "new email" only if primary relay has "process unencrypted" enabled, which will be impossible to enable permanently then.

@link2xt link2xt force-pushed the link2xt/process-unencrypted branch 4 times, most recently from bb4bde4 to b47d145 Compare May 13, 2026 20:48
@link2xt link2xt changed the title WIP: feat: add option to process unencrypted messages Add option to force encryption May 13, 2026
@link2xt link2xt marked this pull request as ready for review May 13, 2026 20:49
@link2xt link2xt marked this pull request as draft May 13, 2026 20:49
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch from b47d145 to c67dc51 Compare May 13, 2026 20:49
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch 3 times, most recently from 15d971f to a1137cb Compare May 14, 2026 18:41
@hpk42 hpk42 added the blocker label May 14, 2026
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch 3 times, most recently from a412867 to 5836a72 Compare May 14, 2026 23:41
@link2xt link2xt changed the base branch from main to link2xt/remove-timesmearing May 15, 2026 00:17
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch from 5836a72 to 098f508 Compare May 15, 2026 00:18
link2xt added 2 commits May 15, 2026 03:47
This change is a preparation for ignoring
unencrypted messages by default.

New test_utils::encrypt_raw_message and
test_utils::receive_encrypted_imf are
used to encrypt the messages before
"receiving" them with receive_imf.
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch from 098f508 to cb8ffb6 Compare May 15, 2026 01:50
@link2xt link2xt force-pushed the link2xt/remove-timesmearing branch from 2b97913 to 5e61bba Compare May 15, 2026 01:50
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch from cb8ffb6 to 95b4ffc Compare May 15, 2026 02:05
@link2xt link2xt force-pushed the link2xt/process-unencrypted branch from 95b4ffc to 6260540 Compare May 15, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to process unencrypted messages

4 participants