feat: Improved SMTP error responses#147
Merged
Merged
Conversation
j-g00da
commented
May 7, 2026
j-g00da
force-pushed
the
j-g00da/better-smtp-errors
branch
2 times, most recently
from
07e586a to
6f6e65d
Compare
hpk42
reviewed
May 8, 2026
j-g00da
force-pushed
the
j-g00da/better-smtp-errors
branch
from
6f6e65d to
5e783a0
Compare
hpk42
approved these changes
May 12, 2026
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
looks good, but indeed makes sense to avoid reporting back internal details to users.
j-g00da
force-pushed
the
j-g00da/better-smtp-errors
branch
3 times, most recently
from
163781c to
3b0608a
Compare
Fixes: #140 Signed-off-by: Jagoda Ślązak <jslazak@jslazak.com>
j-g00da
force-pushed
the
j-g00da/better-smtp-errors
branch
from
3b0608a to
b9f6a34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #140