unbound: generate root.key manually if it doesn't exist#139
Merged
Conversation
link2xt
approved these changes
Dec 19, 2023
| packages="unbound", | ||
| packages=["unbound", "unbound-anchor"], | ||
| ) | ||
| server.shell( |
Contributor
There was a problem hiding this comment.
Maybe add a comment describing why it is needed and link to the issue?
It is definitely no necessary on Ubuntu, so someone may remove it.
Contributor
Author
There was a problem hiding this comment.
Then let's simply only install it on Debian - I pushed a commit.
Contributor
Author
There was a problem hiding this comment.
If you remove it, the next cmdeploy run would just re-install it. Let's just install it unconditionally, and consider removing it after there is a fix.
Contributor
There was a problem hiding this comment.
I mean someone (we year later when we forget about it) will remove it from cmdeploy because we don't understand why it is needed if everything works on some system.
link2xt
reviewed
Dec 19, 2023
This reverts commit c1d3de9.
link2xt
reviewed
Dec 19, 2023
link2xt
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #138