Conversation
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
40bc816 to
89706af
Compare
| server.shell( | ||
| name="Download iroh-relay", | ||
| commands=[ | ||
| "(echo '8af7f6d29d17476ce5c3053c3161db5793cb2ac49057d0bcaf689436cdccbeab /usr/local/bin/iroh-relay' | sha256sum -c) || curl -L https://github.com/n0-computer/iroh/releases/download/v0.27.0/iroh-relay-v0.27.0-x86_64-unknown-linux-musl.tar.gz | gunzip | tar -x -f - ./iroh-relay -O >/usr/local/bin/iroh-relay", |
There was a problem hiding this comment.
what is the checksum check really doing? the check does not happen after the file is downloaded -- so we are basically running an unchecked binary?
There was a problem hiding this comment.
It's just an update mechanism to avoid downloading if the file is already here and has expected checksum.
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
89706af to
ffb51e7
Compare
|
I had to add |
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
374b87a to
e8abe5a
Compare
|
Can also wait for n0-computer/iroh#2847 so we don't need a writable config. |
| http_bind_addr = "[::]:3340" | ||
| enable_stun = true | ||
| enable_metrics = false | ||
| metrics_bind_addr = "127.0.0.1:9092" |
There was a problem hiding this comment.
this address must be set even if "enable_metrics" is false?
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
looks good. But i'd keep an opt-out iroh_relay setting. i.e. upgrading automatically uses iroh.{mail_domain} but if you set iroh_relay = to anything that the systemd-service is not enabled, and Delta Chat users see this setting if it contains something not-empty.
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
565d80a to
2032fac
Compare
missytake
left a comment
missytake
left a comment
There was a problem hiding this comment.
Looks good! One thing:
| elif remote_data["MTA_STS"] != f"{mail_domain}.": | ||
| print("Missing MTA-STS CNAME record:") | ||
| print(f"mta-sts.{mail_domain}. CNAME {mail_domain}.") | ||
| elif require_iroh and remote_data["IROH"] != f"{mail_domain}.": |
There was a problem hiding this comment.
| elif require_iroh and remote_data["IROH"] != f"{mail_domain}.": | |
| elif require_iroh and remote_data["IROH"] != f"iroh.{mail_domain}.": |
This needs to compare against the DNS record being iroh.example.org, right?
There was a problem hiding this comment.
No, this is CNAME record, it should point from iroh.example.org to just example.org.
I think this is not so important. I'll set myself a reminder to |
hpk42
force-pushed
the
link2xt/iroh-relay
branch
from
2032fac to
221e8c9
Compare
hpk42
force-pushed
the
link2xt/iroh-relay
branch
from
3da40eb to
fd2525d
Compare
3 participants
No description provided.