feat!: remove passthrough_sender and passthrough_recipients and warn about unused ini settings - #970
Merged
Conversation
…ate one more source of unencrypted messages When running "cmdeploy run" operators will see a warning if their chatmail.ini contains these unused options.
link2xt
reviewed
May 14, 2026
| self.password_min_length = int(params.get("password_min_length", 9)) | ||
| self.passthrough_senders = params.get("passthrough_senders", "").split() | ||
| self.passthrough_recipients = params.get("passthrough_recipients", "").split() | ||
| _unused = ("passthrough_senders", "passthrough_recipients") |
Contributor
There was a problem hiding this comment.
Maybe use params.pop() instead of params.get() above and then warn about all keys that were not used instead of keeping a list of deprecated keys here?
Contributor
Author
There was a problem hiding this comment.
k, that's a bit more of a refactor and general mechanism then. i added a commit to go for your suggestion.
hpk42
changed the title
link2xt
approved these changes
May 14, 2026
hpk42
added a commit
to chatmail/filtermail
that referenced
this pull request
May 14, 2026
see chatmail/relay#970 for the related removal of chatmail.ini options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this eliminates one more source of unencrypted messages that is hardly used practically.
When running "cmdeploy run" operators will see a warning if their chatmail.ini contains these unused options.