fix: use getent instead of nslookup for redis readiness check#201
Merged
vishnu-narayanan merged 2 commits intomainfrom Apr 1, 2026
Merged
fix: use getent instead of nslookup for redis readiness check#201vishnu-narayanan merged 2 commits intomainfrom
vishnu-narayanan merged 2 commits intomainfrom
Conversation
nslookup in BusyBox v1.37+ (shipped in the chatwoot image) exits 1 when intermediate search domain lookups return NXDOMAIN, even if the final lookup succeeds. This causes the init-redis until loop to hang indefinitely on clusters with ndots:5 (the Kubernetes default). getent hosts uses the system C library resolver which returns the first successful result and exits 0, matching the expected behavior. Fixes #200
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #200
Fixes https://linear.app/chatwoot/issue/INF-65
The
init-redisinit container in the migration job hangs indefinitely on upgrade to 2.0.19. The root cause is thatnslookupin BusyBox v1.37+ (shipped in the chatwoot app image) exits 1 when intermediate search domain lookups return NXDOMAIN, even when the final lookup succeeds. Combined with Kubernetes' defaultndots:5, theuntilloop never exits.This replaces
nslookupwithgetent hosts, which uses the system C library resolver. It returns the first successful result and exits 0 regardless of search domain behavior.Why not the other suggested fixes?
busybox:1.28: This was changed intentionally in 2.0.19 (for INF-61) because orgs with strict image pull policies block external images like busybox. Reverting reintroduces that problem..Release.Namespace.svc.cluster.local: Only works for bundled Redis. Thechatwoot.redis.hosttemplate can return an external hostname whenredis.enabled=false, and appending.namespace.svc.cluster.localto that would break resolution.getent hosts: Works for both bundled and external Redis. Uses the same resolver path as every other application in the container. Available in the chatwoot image (confirmed).Test Plan