Closed
Conversation
chaule97
force-pushed
the
17.0-fix-pos_lot_barcode
branch
6 times, most recently
from
1ee69cd to
7bd196d
Compare
chaule97
force-pushed
the
17.0-fix-pos_lot_barcode
branch
from
7bd196d to
fb9a544
Compare
nilshamerlinck
approved these changes
Aug 26, 2024
nilshamerlinck
left a comment
nilshamerlinck
left a comment
There was a problem hiding this comment.
lgtm, can you prepare a few notes for the final PR?
- as reported in some PRs (see here for example),
pos_lot_barcodetests were failing due a tour - this PR fixes it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.