Skip to content

fix(core): prevent fork bomb on Windows#41

Open
chawyehsu wants to merge 25 commits into
mainfrom
push-qkqzuwqykwkx
Open

fix(core): prevent fork bomb on Windows#41
chawyehsu wants to merge 25 commits into
mainfrom
push-qkqzuwqykwkx

Conversation

@chawyehsu
Copy link
Copy Markdown
Owner

This patch was submitted to upstream in PR volta-cli#1761 and had received code reviews, but obsoleted because of upstream becoming unmaintained. It was also applied in https://github.com/chawyehsu/volta/tree/staging

Fix volta-cli#1741

Fun thing: https://x.com/chawyehsu/status/1784577035064791349

chawyehsu and others added 24 commits May 23, 2024 12:52
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
Co-authored-by: Chris Krycho <hello@chriskrycho.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
@chawyehsu chawyehsu self-assigned this May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 49.29577% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.60%. Comparing base (32cc68e) to head (05f592a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/volta-core/src/command.rs 18.75% 26 Missing ⚠️
crates/volta-core/src/error/kind.rs 0.00% 6 Missing ⚠️
crates/volta-core/src/run/executor.rs 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   73.82%   73.60%   -0.23%     
==========================================
  Files         105      105              
  Lines       10477    10523      +46     
==========================================
+ Hits         7735     7745      +10     
- Misses       2742     2778      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential fork bomb

1 participant