Remove PointerSize attribute (dissect structure RLE compression)#236
Merged
cheat-engine merged 1 commit intocheat-engine:masterfrom Oct 16, 2017
Merged
Conversation
Looks like PointerSize attribute is not needed for pointers when RLE compression is used. I analysed tens of CT files with structures created with CE6.7, and found out that Bytesize attribute is always the same as PointerSize attribute. Conclusion, I can just use TStructelement.fbytesize field (based on just loaded data from XML) instead of TStructelement.Bytesize property (based on processhandler.pointersize when structelement is a pointer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like PointerSize attribute is not needed for pointers when RLE compression is used. I analysed tens of CT files with structures created with CE6.7, and found out that Bytesize attribute is always the same as PointerSize attribute.
Conclusion, I can just use TStructelement.fbytesize field (based on just loaded data from XML) instead of TStructelement.Bytesize property (based on processhandler.pointersize when structelement is a pointer)