Skip to content

PR 126#1

Closed
chebread wants to merge 13 commits intomasterfrom
pr-126
Closed

PR 126#1
chebread wants to merge 13 commits intomasterfrom
pr-126

Conversation

@chebread
Copy link
Copy Markdown
Owner

@chebread chebread commented Mar 26, 2026

I have updated the CI pipeline to use GitHub Actions, replacing the broken Travis CI and AppVeyor setups.

Changes

  • Removed .travis.yml: Travis CI is no longer functional for this repo.
  • Added .github/workflows/ci.yml: A modern, unified pipeline that tests on Ubuntu, macOS, and Windows using Go 1.25.x (matching the updated go.mod).
  • Integrated Quality Checks: The workflow now strictly validates gofmt, go vet, go install, and go test -race on every PR and push to master.

Technical Implementation Details

  • I've explicitly set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true. This prepares the repository for the upcoming Node 20 EOL (April 2026) and ensures the CI remains functional and secure without deprecation warnings.
  • Added workflow_dispatch to allow manual trigger of the CI from the Actions tab, providing better control for debugging or maintenance.
  • Strict Quality Gate
    • gofmt: Ensures all contributions follow the standard Go style, reducing reviewer burden.
    • go vet: Catch common logical errors at the CI stage.
    • Beyond unit tests, I've added go run ./cmd/devd --help to verify the final binary's execution integrity across all platforms.

Note on AppVeyor

I found that AppVeyor was likely configured via the Web UI rather than a .appveyor.yml file, as no such file existed in the root. Therefore, I could not "delete" its configuration via git. Once this PR is merged, the repository owner should manually disable the AppVeyor project in its admin dashboard to avoid redundant (and failing) builds.

Verification

I have verified this entire workflow on my fork, and all three OS environments passed the build and test suites successfully.

leg100 and others added 13 commits July 13, 2022 10:01
Synced with golang std http fs_test.go
https://github.com/golang/go/blob/456a90aa1618a6c3aa49ecba46969128e2bfa26f/src/net/http/fs_test.go#L607

See upstream comment why this is needed.

We should probably rebase devd fileserver.* on latest golang fs.*
This commit changes the default virtual hosting domain from devd.io to  localhost (and *.localhost).

Resolves cortesi#128
Replace devd.io with localhost for local routing
…tEncoding

Fix failing TestServeFileWithContentEncoding
Update readme go install process
…being-set

Use HTTPS scheme when specifying cert file
Remove broken Travis CI configuration (.travis.yml)
Add GitHub Actions workflow for testing on ubuntu, macos, and windows
Strictly test on Go 1.25.x to match the go.mod directive
Include gofmt, go vet, and go install to ensure build integrity
@chebread chebread changed the title Pr 126 [PR #126] Updated CI to GitHub Actions and verified on Fork Mar 26, 2026
@chebread chebread changed the title [PR #126] Updated CI to GitHub Actions and verified on Fork Update CI to GitHub Actions Mar 26, 2026
@chebread chebread closed this Mar 26, 2026
@chebread chebread changed the title Update CI to GitHub Actions PR 126 Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants