Skip to content

add new rule to make sure awaited service calls have response variables declared with#113

Merged
le-cong merged 4 commits intomainfrom
no-undeclared-service-call
Feb 5, 2025
Merged

add new rule to make sure awaited service calls have response variables declared with#113
le-cong merged 4 commits intomainfrom
no-undeclared-service-call

Conversation

@le-cong
Copy link
Contributor

@le-cong le-cong commented Feb 4, 2025

Fixes #112

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name typings.test.ts if it's only used in tests?

: never
: never;

// type BodyArgument<Context> = Context extends { request: { body: infer Body } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented-out code

@le-cong le-cong requested a review from carlansley February 5, 2025 18:34
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Coverage after merging no-undeclared-service-call into main will be

85.04%▾ -0.01%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   file-path-comment.ts100%100%100%100%
   get-documentation-url.ts100%100%100%100%
   index.ts0%0%0%0%1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–139, 14, 140–149, 15, 150–151, 16–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
   invalid-json-stringify.ts100%100%100%100%
   no-card-numbers.ts95.11%89.29%100%96.03%134–139, 144–146
   no-duplicated-imports.ts100%100%100%100%
   no-enum.ts100%100%100%100%
   no-legacy-service-typing.ts100%100%100%100%
   no-promise-instance-method.ts100%100%100%100%
   no-random-v4-uuid.ts100%100%100%100%
   no-serve-runtime.ts100%100%100%100%
   no-side-effects.ts99.54%97.83%100%100%132
   no-status-code-assert.ts100%100%100%100%
   no-test-import.ts100%100%100%100%
   no-uuid.ts95.16%85.71%100%96.23%100–101, 89–91, 99
   no-wallaby-comment.ts97.50%85%100%100%43–44, 58
   object-literal-response.ts100%100%100%100%
   regular-expression-comment.ts95.51%89.47%100%97.06%35–37, 54
   require-assert-predicate-rejects-throws.ts100%100%100%100%
   require-fixed-services-import.ts100%100%100%100%
   require-resolve-full-response.ts83.69%78.33%100%84.72%105–107, 109–111, 113–115, 122–124, 127, 129, 129–131, 147–149, 199–210, 46, 65, 65–67, 81–83, 94–99
   require-service-call-response-declaration.ts84.81%80%100%84.72%55–66
   require-strict-assert.ts98.40%92%100%100%44–45
   require-ts-extension-imports-exports.ts100%100%100%100%
   require-type-out-of-type-only-imports.ts100%100%100%100%
   service.ts100%100%100%100%
   tester.test.ts100%100%100%100%
   ts-tester.test.ts100%100%100%100%
src/library
   format.ts0%0%0%0%1, 1, 10–19, 2, 20, 3–9
   tree.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–97
   ts-tree.ts47.58%46.15%37.50%48.54%100–103, 27–29, 29–30, 33, 33–35, 35–37, 42–43, 46–47, 56–74, 77–92, 95–99
   variable.ts0%0%0%0%1, 1–5

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Beta Published - Install Command: npm install @checkdigit/eslint-plugin@7.11.0-PR.113-e5f6

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

✅ PR review status - All reviews completed and approved!

@le-cong le-cong merged commit 8897ad0 into main Feb 5, 2025
11 of 12 checks passed
@le-cong le-cong deleted the no-undeclared-service-call branch February 5, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new rule - disallow awaited service call's response not being checked upon

3 participants