Remove axios from the notAllowed list, as it is used by multiple services.#99
Merged
Remove axios from the notAllowed list, as it is used by multiple services.#99
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the check-imports action configuration to stop blocking axios, aligning the “not allowed” package list with current usage across services (Issue #98).
Changes:
- Remove
axiosfrom thenotAllowedpackage list. - Update the corresponding unit test to no longer expect
axiosto be blocked. - Bump package version to
4.0.2and updatepackage-lock.json.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/check-imports/packages-not-allowed.ts | Removes the axios block entry from the not-allowed list. |
| src/check-imports/packages-not-allowed.spec.ts | Removes the test asserting axios is fully blocked. |
| package.json | Bumps package version to 4.0.2. |
| package-lock.json | Updates lockfile version fields and dependency metadata; removes some package entries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Coverage after merging remove-axios-not-allowed into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lukebrdn
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98