Skip to content

Conversation

@maxigimenez
Copy link
Member

@maxigimenez maxigimenez commented Dec 2, 2025

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Add .yml support to project bundler, as Playwright aria-snapshots generates yml file.

Tested:

npx checkly test --record
npx checkly pw-test
npx checkly deploy and running check on a schedule all works

@sorccu
Copy link
Member

sorccu commented Dec 2, 2025

I think you should just add the extension here:

const STATIC_FILE_EXTENSION = ['.json', '.txt', '.jpeg', '.jpg', '.png']

Can you give that a go?

Also, #1153 will remove this list entirely but it is not ready yet.

Copy link
Member

@sorccu sorccu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment

@maxigimenez maxigimenez requested a review from sorccu December 2, 2025 10:53
Copy link
Member

@sorccu sorccu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will do for now.

@maxigimenez maxigimenez enabled auto-merge (squash) December 2, 2025 10:54
@maxigimenez maxigimenez merged commit 60a33cd into main Dec 2, 2025
3 checks passed
@maxigimenez maxigimenez deleted the maxi/kit-2376-customer-issue-with-yml-files-for-aria-snapshots-not branch December 2, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants