Skip to content

feat(cli): add --status flag to checks list command [AI-35]#1244

Merged
martzoukos merged 3 commits intomainfrom
martzoukos/ai-35/add-status-to-checkslist
Mar 9, 2026
Merged

feat(cli): add --status flag to checks list command [AI-35]#1244
martzoukos merged 3 commits intomainfrom
martzoukos/ai-35/add-status-to-checkslist

Conversation

@martzoukos
Copy link
Contributor

@martzoukos martzoukos commented Mar 5, 2026

You can now filter the fetched checks by their status (passing, failing, degraded):

image

It has been tested against production's Production E2E MaC account for the following scenarios:

  • Rejects bad values on the client side (oclif validation), not the backend
  • Successfully filters checks by the passed value
  • Can be combined with other params (like type)

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Filter checks by passing, failing, or degraded status using the
server-side status query parameter.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MichaelHogers
MichaelHogers previously approved these changes Mar 5, 2026
Copy link
Contributor

@MichaelHogers MichaelHogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one comment/thought:

should we also test against an empty prod e2e account?

Image

new users start with empty accounts, we might miss an edge case when testing only against our own e2e account

(more of a general comment, not specific to your PR)

@sorccu for your visibility as well

@MichaelHogers
Copy link
Contributor

@martzoukos the windows test can be/is flaky, not sure about the ubuntu one tho

@martzoukos
Copy link
Contributor Author

martzoukos commented Mar 5, 2026

The testing stuff is still a bit fuzzy to me @MichaelHogers , I thought of piggybacking on what we already have and just adding one extra check for the statuses but I also see that this is the first test in that file that depends on the user's content (so, indeed, fresh accounts will always fail that test and considering that this is an OSS project, we can't assume that most users will already have a nice account with a lot of checks).

The failed tests actually both fail in the same step: npx checkly deploy --force 🤔

Should I go ahead and remove this test? I'm not sure if it adds a lot of value vs the effort it might require at this point of time.

@martzoukos martzoukos removed the request for review from hwartig March 5, 2026 15:15
@martzoukos martzoukos force-pushed the martzoukos/ai-35/add-status-to-checkslist branch from ec59d2d to bfd2bbb Compare March 5, 2026 15:18
MichaelHogers
MichaelHogers previously approved these changes Mar 5, 2026
Copy link
Contributor

@MichaelHogers MichaelHogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@martzoukos martzoukos force-pushed the martzoukos/ai-35/add-status-to-checkslist branch from 62b18b6 to 5e11241 Compare March 6, 2026 09:28
@martzoukos martzoukos enabled auto-merge (squash) March 6, 2026 09:32
@martzoukos martzoukos merged commit 82bbecb into main Mar 9, 2026
4 checks passed
@martzoukos martzoukos deleted the martzoukos/ai-35/add-status-to-checkslist branch March 9, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants