feat(cli): add --status flag to checks list command [AI-35]#1244
feat(cli): add --status flag to checks list command [AI-35]#1244martzoukos merged 3 commits intomainfrom
Conversation
Filter checks by passing, failing, or degraded status using the server-side status query parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Looks good to me, one comment/thought:
should we also test against an empty prod e2e account?
new users start with empty accounts, we might miss an edge case when testing only against our own e2e account
(more of a general comment, not specific to your PR)
@sorccu for your visibility as well
|
@martzoukos the windows test can be/is flaky, not sure about the ubuntu one tho |
|
The testing stuff is still a bit fuzzy to me @MichaelHogers , I thought of piggybacking on what we already have and just adding one extra check for the statuses but I also see that this is the first test in that file that depends on the user's content (so, indeed, fresh accounts will always fail that test and considering that this is an OSS project, we can't assume that most users will already have a nice account with a lot of checks). The failed tests actually both fail in the same step: Should I go ahead and remove this test? I'm not sure if it adds a lot of value vs the effort it might require at this point of time. |
ec59d2d to
bfd2bbb
Compare
62b18b6 to
5e11241
Compare
You can now filter the fetched checks by their
status(passing, failing, degraded):It has been tested against production's
Production E2E MaCaccount for the following scenarios:oclifvalidation), not the backendAffected Components