feat(domain): add option to set controller domain#52
Conversation
akosveres
commented
Nov 11, 2024
akosveres
commented
- Add new command line flag for a controller domain
- Update docs
| flag.BoolVar(&enableLeaderElection, "leader-elect", false, | ||
| "Enable leader election for controller manager. "+ | ||
| "Enabling this will ensure there is only one active controller manager.") | ||
| flag.StringVar(&controllerDomain, "controller-domain", "k8s.checklyhq.com", "Domain to use for annotations and finalizers.") |
There was a problem hiding this comment.
This may not be the best naming of this ... but it's here, so please, suggest better ones and I'll update the PR.
There was a problem hiding this comment.
I've asked our k8s users for their opinion, but to me (as a lightweight user) it seems alright.
There was a problem hiding this comment.
There was a problem hiding this comment.
is this the prefix? https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set
I'm not sure I understand the question.
There was a problem hiding this comment.
I mean if the controller-domain is the same concept as the prefix mentioned here
There was a problem hiding this comment.
Yes, @pelzerim, correct, that's exactly what this is supposed to be, I just never seen this doc :D
* Add new command line flag for a controller domain * Update docs
akosveres
force-pushed
the
controller_domain
branch
from
b192bdc to
5d66cbb
Compare
sorccu
left a comment
sorccu
left a comment
There was a problem hiding this comment.
Changes look good and straightforward to me.
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
This could be used to work with different operator deployment, which is great. Alternative is to use version value on whichever domain. Here I see option to use |
4 participants
