Skip to content

fix: 소셜 로그인 관리 네이버 로그 수정#227

Merged
shinwokkang merged 1 commit intodevfrom
feat/221-withdrawal-and-social
Mar 21, 2026
Merged

fix: 소셜 로그인 관리 네이버 로그 수정#227
shinwokkang merged 1 commit intodevfrom
feat/221-withdrawal-and-social

Conversation

@shinwokkang
Copy link
Contributor

📌 개요 (Summary)

  • 변경 사항에 대한 간략한 요약을 적어주세요.
  • 관련 이슈가 있다면 링크를 걸어주세요 (예: [fix] cicd / build 문제 #123).

🛠️ 변경 사항 (Changes)

  • 새로운 기능 추가
  • 버그 수정
  • 코드 리팩토링
  • 문서 업데이트
  • 기타 (설명: )

📸 스크린샷 (Screenshots)

(UI 변경 사항이 있다면 첨부해주세요)

✅ 체크리스트 (Checklist)

  • 빌드가 성공적으로 수행되었나요? (pnpm build)
  • 린트 에러가 없나요? (pnpm lint)
  • 불필요한 콘솔 로그나 주석을 제거했나요?

@vercel
Copy link

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
check-mo Building Building Preview Mar 21, 2026 7:24am

@coderabbitai
Copy link

coderabbitai bot commented Mar 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bc8e24e3-79c3-4bbf-a7e4-6595ee01456c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/221-withdrawal-and-social

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 소셜 로그인 카드 컴포넌트에서 Google 및 Naver 아이콘이 올바르게 표시되도록 이미지 경로를 수정합니다. 기존 아이콘 파일명이 변경되어 발생한 문제를 해결하여 사용자 인터페이스의 일관성을 유지합니다.

Highlights

  • 소셜 로그인 아이콘 경로 수정: Google 및 Naver 소셜 로그인 제공자의 아이콘 경로가 업데이트되었습니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 SocialLoginCard.tsx 파일에서 소셜 로그인 제공업체(네이버, 구글)의 로고 이미지 경로를 업데이트합니다. 변경된 네이버 로고의 배경색 정의 방식에 대해 Tailwind CSS 모범 사례를 따르는 개선을 제안합니다.

google: { bgColor: "bg-White border border-Gray-2", icon: "/google.svg" },
naver: { bgColor: "bg-[#03C75A]", icon: "/naver.svg" },
google: { bgColor: "bg-White border border-Gray-2", icon: "/googleLogo.svg" },
naver: { bgColor: "bg-[#03C75A]", icon: "/naverLogo.svg" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

네이버 로고의 배경색으로 직접적인 hex 코드를 사용하는 대신, Tailwind CSS 설정 파일에 해당 색상을 정의하고 이름으로 참조하는 것이 좋습니다. 이는 색상 관리의 일관성을 높이고 향후 유지보수를 용이하게 합니다.

@shinwokkang shinwokkang merged commit adaf3b2 into dev Mar 21, 2026
4 checks passed
@shinwokkang shinwokkang deleted the feat/221-withdrawal-and-social branch March 21, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant