fix: non-breaking security improvements#562
Merged
armando-rodriguez-cko merged 2 commits intomasterfrom Mar 30, 2026
Merged
Conversation
Contributor
armando-rodriguez-cko
commented
Mar 24, 2026
armando-rodriguez-cko
commented
- Replace System.err.println with log.warn in GsonSerializer to route deserialization errors through the standard logging framework instead of bypassing it via stderr
- Exclude responseHeaders from CheckoutApiException @tostring to prevent raw response headers being inadvertently written to logs when the exception is stringified; errorDetails remains visible for debugging
david-ruiz-cko
previously approved these changes
Mar 24, 2026
david-ruiz-cko
approved these changes
Mar 30, 2026
- Replace System.err.println with log.warn in GsonSerializer to route deserialization errors through the standard logging framework instead of bypassing it via stderr - Exclude responseHeaders from CheckoutApiException @tostring to prevent raw response headers being inadvertently written to logs when the exception is stringified; errorDetails remains visible for debugging
The sanitiseHeaders helper already filtered the Authorization header before logging. Extend it to also filter Cko-Idempotency-Key so that idempotency tokens are not written to INFO logs in plain text.
armando-rodriguez-cko
force-pushed
the
bugfix/security-non-breaking-improvements
branch
from
afef321 to
cd2a265
Compare
|
armando-rodriguez-cko
deleted the
bugfix/security-non-breaking-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.