Skip to content

feature/INT-1631 - updates the handling file purposes in the codebase#600

Merged
david-ruiz-cko merged 1 commit into
masterfrom
feature/INT-1631
May 21, 2026
Merged

feature/INT-1631 - updates the handling file purposes in the codebase#600
david-ruiz-cko merged 1 commit into
masterfrom
feature/INT-1631

Conversation

@david-ruiz-cko
Copy link
Copy Markdown
Contributor

This pull request updates the handling of file purposes in the codebase to use a type-safe enum instead of raw strings, and adds support for additional file purposes. The changes improve code reliability and clarity by enforcing the use of the FilePurpose enum throughout the code and by expanding the recognized file purposes.

File Purpose Handling Improvements:

  • Changed the purpose field in FileDetailsResponse from a String to the FilePurpose enum, ensuring type safety and consistency.
  • Updated the FilePurpose enum to include new purposes: ARBITRATION_EVIDENCE and SUBMITTED_EVIDENCE, with appropriate serialization annotations for JSON mapping.

Test Adjustments:

  • Updated test assertions in DisputesTestIT.java and previous/DisputesTestIT.java to compare FilePurpose enum values directly instead of comparing strings, reflecting the new type-safe approach. [1] [2]

@david-ruiz-cko david-ruiz-cko requested a review from a team May 21, 2026 09:21
@sonarqubecloud
Copy link
Copy Markdown

@david-ruiz-cko david-ruiz-cko merged commit c2640a1 into master May 21, 2026
6 checks passed
@david-ruiz-cko david-ruiz-cko deleted the feature/INT-1631 branch May 21, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants