lsm: handle half initialized SELinux setups#1457
Merged
avagin merged 1 commit intocheckpoint-restore:criu-devfrom May 8, 2021
Merged
lsm: handle half initialized SELinux setups#1457avagin merged 1 commit intocheckpoint-restore:criu-devfrom
avagin merged 1 commit intocheckpoint-restore:criu-devfrom
Conversation
adrianreber
force-pushed
the
2021-04-27-selinux
branch
from
0779531 to
8a4f723
Compare
Codecov Report
@@ Coverage Diff @@
## criu-dev #1457 +/- ##
============================================
- Coverage 68.83% 68.72% -0.11%
============================================
Files 133 133
Lines 32318 32327 +9
============================================
- Hits 22245 22217 -28
- Misses 10073 10110 +37
Continue to review full report at Codecov.
|
rst0git
reviewed
May 3, 2021
CRIU used to check for the existence of /sys/fs/selinux to see if SELinux is enabled on a system. We have seen systems with SELinux kind of enabled but reading out the labels gives does not return real labels. To work around this, this commit adds a check during LSM detection if SELinux labels are in the right format. For CRIU this check means to see if there are at least 3 ':' in a label. If not CRIU switches to no LSM mode. Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
2021-04-27-selinux
branch
from
8a4f723 to
5e90fdf
Compare
rst0git
approved these changes
May 3, 2021
rajbhar
approved these changes
May 7, 2021
Contributor
rajbhar
left a comment
rajbhar
left a comment
There was a problem hiding this comment.
Looks good to me.
Tested-by: Rajneesh Bhardwaj rajneesh.bhardwaj@amd.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRIU used to check for the existence of /sys/fs/selinux to see if SELinux is enabled on a system. We have seen systems with SELinux kind of enabled but reading out the labels gives does not return real labels.
To work around this, this commit adds a check during LSM detection if SELinux labels are in the right format. For CRIU this check means to see if there are at least 3 ':' in a label. If not CRIU switches to no LSM mode.
Fixes: #1402