Add headers rendering and example of basicauth#74
Merged
zhouzhuojie merged 2 commits intomasterfrom Apr 28, 2020
Merged
Conversation
michelleheh
reviewed
Apr 28, 2020
|
|
||
| a.Headers, err = renderHeaders(ctx, a.Headers) | ||
| if err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
Should we add the same logrus to be consistent with the render of body failure?
Contributor
There was a problem hiding this comment.
Never mind, I see that it's happening in renderHeaders.
michelleheh
approved these changes
Apr 28, 2020
Contributor
michelleheh
left a comment
There was a problem hiding this comment.
Works great! 👍Will you consider adding a unit test? Also, it will be great to add some information to the README.
|
|
||
| a.Headers, err = renderHeaders(ctx, a.Headers) | ||
| if err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
Never mind, I see that it's happening in renderHeaders.
jpatdalton
approved these changes
Apr 28, 2020
sesquipedalian-dev
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the headers in
reply_httpandsend_httpare not rendered with the context, this PR adds that so that headers can also be dynamic.Example: