Issue with Triggering Branch Coverage for Specific Indentation Cases.

[Praveen7294]

Hi,
I'm currently working on PR #16879 and I'm stuck with Jacoco plugin warnings for rule violations.

To address this issue, I initially reduced the branch and line coverage, but the maintainers do not allow this approach. As an alternative solution, I generated the JaCoCo report using mvn jacoco:report and found that two classes in the indentation folder violate the coverage rules: ArrayInitHandler and AnnotationArrayInitHandler.

ArrayInitHandler https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/indentation/ArrayInitHandler.java

All the possible test cases are already included in:

• InputIndentationInvalidArrayInitIndent.java

• InputIndentationInvalidArrayInitIndent1.java

https://github.com/checkstyle/checkstyle/blob/master/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationInvalidArrayInitIndent.java
https://github.com/checkstyle/checkstyle/blob/master/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationInvalidArrayInitIndent1.java

After debugging the methods getChildrenExpectedIndent() and getNextFirstNonBlankOnLineAfter(int lineNo, int columnNo), I found the following:

• The condition realColumnNo == lineLength is never true for any input when an indentation comment is present.

• Similarly, the condition realColumnNo < lineLength is never false if the indentation comment is present.

If we omit the indentation comment, it triggers the branches mentioned above—but Checkstyle expects the indentation comment to be present.

same explanation for this class also AnnotationArrayInitHandler

AnnotationArrayInitHandler

@romani can you help me with this?

[romani]

as Checkstyle expects the indentation comment to be present.

This is good enough reason to have exception from rule to allow test inputs without comments.

Please make test without trailing comments and above test please put comments with link to this discussion to explain reason of not following rules.

[Praveen7294]

Thank you for guiding me.

[Praveen7294]

If we omit the indentation comment, it triggers the branches mentioned above—but Checkstyle expects the indentation comment to be present.

Sorry, my previous statement wasn't accurate.