Issue #11357: Report correct violation in lambda return

[OttoKaaij]

Fixes #11357. Had to fix some tests, also in the SwitchExpression test

Diff Regression config: https://gist.githubusercontent.com/OttoKaaij/363ce8a2a1007b4a3856cda24bb4e1c6/raw/4e6e0ec1c7b56bc728034e36ec498527c7aa2f8d/my_checks.xml

Regression report: https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cdec517_2022140934/reports/diff/index.html

[nrmancuso]

Please generate check regression report, you can find details here: https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#report-generation

[OttoKaaij]

@nick-mancuso Before I generate the regression report, could you check if the config is correct like this?

[nrmancuso]

@nick-mancuso Before I generate the regression report, could you check if the config is correct like this?

Config looks good, you don't have to specify the projects file, we have default for github action.

[OttoKaaij]

GitHub, generate report

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cdec517_2022140934/reports/diff/index.html

[nrmancuso]

Please extend your new input file to include cases like:

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cdec517_2022140934/reports/diff/apache-ant/xref/home/runner/work/checkstyle/checkstyle/contribution/checkstyle-tester/repositories/apache-ant/src/tests/junit/org/apache/tools/ant/taskdefs/XmlPropertyTest.java.html#L360

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cdec517_2022140934/reports/diff/checkstyle/xref/home/runner/work/checkstyle/checkstyle/contribution/checkstyle-tester/repositories/checkstyle/src/test/resources/com/puppycrawl/tools/checkstyle/checks/indentation/indentation/InputIndentationValidClassDefIndent.java.html#L144

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cdec517_2022140934/reports/diff/hibernate-orm/xref/home/runner/work/checkstyle/checkstyle/contribution/checkstyle-tester/repositories/hibernate-orm/hibernate-core/src/test/java/org/hibernate/test/bytecode/enhancement/customer/CustomerEnhancerTest.java.html#L100

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/cdec517_2022140934/reports/diff/spring-framework/xref/home/runner/work/checkstyle/checkstyle/contribution/checkstyle-tester/repositories/spring-framework/spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAttributeSourceAdvisor.java.html#L46

[OttoKaaij]

Please extend your new input file to include cases like:

Should be done!

[nrmancuso]

Ci failure is not related, but is consistent: https://checkstyle.semaphoreci.com/jobs/92d3c7fd-7382-4984-991a-4ee4eb4da260

Execution default of goal org.antlr:antlr4-maven-plugin:4.9.3:antlr4 failed: A required class was missing while executing org.antlr:antlr4-maven-plugin:4.9.3:antlr4: org/stringtemplate/v4/STGroup

I suppose this is a problem downloading some ANTLR dependency.