Skip to content

Conversation

@SheikhZaeem
Copy link
Contributor

@SheikhZaeem SheikhZaeem commented Mar 10, 2025

Issue: #14631

Command
java -jar checkstyle-10.21.4-all.jar -J Test.java | sed "s/\[[0-9]\+:[0-9]\+\]//g"

Test.java

/**
 * <dd></dd>
 */
public class Test {
}
--HTML_ELEMENT -> HTML_ELEMENT
    `--DD -> DD
        |--DD_TAG_START -> DD_TAG_START
        |   |--START -> <
        |   |--DD_HTML_TAG_NAME -> dd
        |   `--END -> >
        |--TEXT -> "Description content"
        `--DD_TAG_END -> DD_TAG_END
            |--START -> <
            |--SLASH -> /
            |--DD_HTML_TAG_NAME -> dd
            `--END -> >

@SheikhZaeem SheikhZaeem force-pushed the javadocUpdate branch 3 times, most recently from 4e8017d to 2db567e Compare March 10, 2025 10:22
Copy link
Collaborator

@timurt timurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romani cc

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items

@SheikhZaeem SheikhZaeem force-pushed the javadocUpdate branch 3 times, most recently from 913667d to c5aee55 Compare March 15, 2025 09:28
@romani
Copy link
Member

romani commented Mar 15, 2025

still , I do not see text in DD

@SheikhZaeem
Copy link
Contributor Author

SheikhZaeem commented Mar 16, 2025

why would there even be a Performance errror :( didn't happen with DT PR

@timurt
Copy link
Collaborator

timurt commented Mar 17, 2025

why would there even be a Performance errror :( didn't happen with DT PR

Hey @SheikhZaeem, not sure why it is happening, but I have a suspicion that it is just flaky
I have no permission to retry failed job, could you please retrigger CI by updating your PR (rebase or small change)

@romani
Copy link
Member

romani commented Mar 17, 2025

Restarted

@romani
Copy link
Member

romani commented Mar 17, 2025

Please update PR description to show AST from CLI

@SheikhZaeem
Copy link
Contributor Author

Please update PR description to show AST from CLI

@romani done

@romani
Copy link
Member

romani commented Mar 17, 2025

I still see <dd></dd>

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

public static final int COLGROUP_TAG_END = JavadocParser.RULE_colgroupTagEnd
+ RULE_TYPES_OFFSET;

/** Description of a term html tag: {@code <dd></dd>}. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore {@code <dd></dd>}

as
{@code <dd>Description content</dd>}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and update PR description with CLI output for it.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot

@romani romani merged commit 381a852 into checkstyle:master Apr 1, 2025
114 of 115 checks passed
@SheikhZaeem SheikhZaeem deleted the javadocUpdate branch April 2, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants