-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Issue #14631: Updated DD in JavadocTokenTypes.java to new AST format #16516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e8017d to
2db567e
Compare
timurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@romani cc
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items
src/main/java/com/puppycrawl/tools/checkstyle/api/JavadocTokenTypes.java
Outdated
Show resolved
Hide resolved
2db567e to
d9e9ad8
Compare
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items
src/main/java/com/puppycrawl/tools/checkstyle/api/JavadocTokenTypes.java
Outdated
Show resolved
Hide resolved
d9e9ad8 to
fa3f0e7
Compare
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Items
src/main/java/com/puppycrawl/tools/checkstyle/api/JavadocTokenTypes.java
Show resolved
Hide resolved
913667d to
c5aee55
Compare
|
still , I do not see text in DD |
0a6e709 to
af821de
Compare
|
why would there even be a Performance errror :( didn't happen with DT PR |
Hey @SheikhZaeem, not sure why it is happening, but I have a suspicion that it is just flaky |
|
Restarted |
|
Please update PR description to show AST from CLI |
@romani done |
|
I still see |
af821de to
6e0de17
Compare
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items:
| public static final int COLGROUP_TAG_END = JavadocParser.RULE_colgroupTagEnd | ||
| + RULE_TYPES_OFFSET; | ||
|
|
||
| /** Description of a term html tag: {@code <dd></dd>}. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restore {@code <dd></dd>}
as
{@code <dd>Description content</dd>}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and update PR description with CLI output for it.
6e0de17 to
18c1b19
Compare
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot
Issue: #14631
Command
java -jar checkstyle-10.21.4-all.jar -J Test.java | sed "s/\[[0-9]\+:[0-9]\+\]//g"Test.java