Skip to content

Conversation

@shivammm21
Copy link

Issue: #16729

Added examples to demonstrate usage of "column" and "id" properties in SuppressionSingleFilter:

  1. Added "column" property to Example1.java
  2. Modified Example2.java to use "id" property instead of "checks"
  3. Created Example11.java showing combined usage of both properties
  4. Updated documentation in suppressionsinglefilter.xml.template
  5. Added tests in SuppressionSingleFilterExamplesTest.java

@shivammm21
Copy link
Author

I've added Example11.java to demonstrate both 'column' and 'id' properties together, and also updated Example1.java and Example2.java to show these properties individually.

I've modified the suppressionsinglefilter.xml.template but I wasn't able to run the site generation locally to create the corresponding XML files. This may be causing the CI failures in language-specific tests.

Please advise on any additional files that need to be updated to make this PR complete.

@Brijeshthummar02
Copy link
Contributor

Multiple Checks are failing we need to see it and fix it locally.

@shivammm21
Copy link
Author

shivammm21 commented Apr 3, 2025

@Brijeshthummar02 Noted. I wasn’t able to generate the XML files locally, which might be causing the CI failures. Do you have any suggestions on debugging this? Let’s check the logs together and fix it.

@Brijeshthummar02
Copy link
Contributor

As i see you're new to checkstyle i highly recommend this debuging video [ https://youtu.be/cRCoDfmgsJw?si=RDZXGIq3yNnzEXjz ] also if you want u can have a look to complete playlist.

@Brijeshthummar02
Copy link
Contributor

Brijeshthummar02 commented Apr 3, 2025

@shivammm21 please have a look to this documentation https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#checkstyle-tester .

https://checkstyle.org/beginning_development.html#Starting_Development

@shivammm21
Copy link
Author

Thank you. I will check the documentation for the testing again. I will create pr.

@Brijeshthummar02
Copy link
Contributor

Brijeshthummar02 commented Apr 3, 2025

Thank you. I will check the documentation for the testing again. I will create pr.

Over there u will find section about Report generation - manual as well as automatic.

@romani
Copy link
Member

romani commented Apr 4, 2025

Please read and watch videos at Starting_Development.
Please make CI green.

@romani
Copy link
Member

romani commented Jul 28, 2025

@shivammm21 , do you have energy to finish PR ?

@shivammm21
Copy link
Author

Yes, I’ll resume work on this and make sure the CI passes. Expect an update soon.

@github-actions
Copy link
Contributor

Hello 👋!

It looks like this pull request has been inactive for a while.
Could you provide the requested feedback?
If no response is received in the next 60 days, we will close this pull request.

🚧 This Github Action is under testing, please let us know if it is misbehaving. 🚧

@github-actions github-actions bot added the Stale label Aug 13, 2025
@github-actions
Copy link
Contributor

Hello 👋!

Since we haven't received any feedback, we are closing this pull request.
If you have any questions or need further assistance,
please feel free to reopen this pull request.

🚧 This Github Action is under testing, please let us know if it is misbehaving. 🚧

@github-actions github-actions bot closed this Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants