-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Issue #16729: Update SuppressionSingleFilter examples to use all prop… #16745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #16729: Update SuppressionSingleFilter examples to use all prop… #16745
Conversation
|
I've added Example11.java to demonstrate both 'column' and 'id' properties together, and also updated Example1.java and Example2.java to show these properties individually. I've modified the suppressionsinglefilter.xml.template but I wasn't able to run the site generation locally to create the corresponding XML files. This may be causing the CI failures in language-specific tests. Please advise on any additional files that need to be updated to make this PR complete. |
|
Multiple Checks are failing we need to see it and fix it locally. |
|
@Brijeshthummar02 Noted. I wasn’t able to generate the XML files locally, which might be causing the CI failures. Do you have any suggestions on debugging this? Let’s check the logs together and fix it. |
|
As i see you're new to checkstyle i highly recommend this debuging video [ https://youtu.be/cRCoDfmgsJw?si=RDZXGIq3yNnzEXjz ] also if you want u can have a look to complete playlist. |
|
@shivammm21 please have a look to this documentation https://github.com/checkstyle/contribution/tree/master/checkstyle-tester#checkstyle-tester . https://checkstyle.org/beginning_development.html#Starting_Development |
|
Thank you. I will check the documentation for the testing again. I will create pr. |
Over there u will find section about Report generation - manual as well as automatic. |
|
Please read and watch videos at Starting_Development. |
|
@shivammm21 , do you have energy to finish PR ? |
|
Yes, I’ll resume work on this and make sure the CI passes. Expect an update soon. |
|
Hello 👋! It looks like this pull request has been inactive for a while. 🚧 This Github Action is under testing, please let us know if it is misbehaving. 🚧 |
|
Hello 👋! Since we haven't received any feedback, we are closing this pull request. 🚧 This Github Action is under testing, please let us know if it is misbehaving. 🚧 |
Issue: #16729
Added examples to demonstrate usage of "column" and "id" properties in SuppressionSingleFilter: