Config: use new treewalker property to skip non-compiled files in regression

[mahfouz72]

blocked until checkstyle/checkstyle#15204

[mahfouz72]

@romani ping please can you help to fix CI

failed during checkstyle configuration: Property 'skipFileOnJavaParseException' does not exist, please check the documentation. Do we need to get a release first to detect new properties?

[rnveach]

https://app.circleci.com/pipelines/github/checkstyle/contribution/357/workflows/3b96ba65-6f9f-4f5a-aeaf-0685f220ed0f/jobs/2476

com.puppycrawl.tools.checkstyle.api.CheckstyleException: Property 'skipFileOnJavaParseException' does not exist, please check the documentation

@mahfouz72 This is not a Checker property.

[rnveach]

#877 (comment)

[mahfouz72]

@rnveach done

[romani]

Item

[romani]

Please put them under other Checker properties. Group them together above , before first inner module

[mahfouz72]

Please put them under other Checker properties.

This is not checker property. Do you mean at the first line in tree walker module? like this

    <module name="TreeWalker">
         <!-- as we run on regression even on non-compiled files we need to skip exceptions on them -->
         <property name="skipFileOnJavaParseException" value="true"/>
         <property name="javaParseExceptionSeverity" value="ignore"/>

         <!-- Example of checkstyle Check usage -->
         <!-- PLEASE CHANGE IT TO CHECK YOU ARE TESTING !!!! -->
         <module name="ThrowsCount">
             <property name="max" value="20000000"/>
         </module>

         <!-- Example of sevntu.checkstyle Check usage -->
         <!-- <module name="NestedSwitchCheck"/> -->

         <!-- suppress javadoc parsing errors, as we test Check not a parser -->
         <module name="SuppressionXpathSingleFilter">
            <property name="message" value="Javadoc comment at column \d+ has parse error"/>
         </module>
    </module>

[mahfouz72]

I prefer to put it after the filter and leave the check modules above, right after <module name="TreeWalker">

[romani]

Treewalker, yes, all propertties are on most top before any inner modules.

 <module name="TreeWalker">
         <!-- as we run on regression even on non-compiled files we need to skip exceptions on them -->
         <property name="skipFileOnJavaParseException" value="true"/>
         <property name="javaParseExceptionSeverity" value="ignore"/>

I insisting on this format.

[mahfouz72]

Okay, done

[nrmancuso]

This has been killing me for years, thank you for fixing this.

[romani]

@relentless-pursuit , please subscribe to this PR, as we merge please update test-configs repo with new content of template config.