Merged
Conversation
skatkov
force-pushed
the
remove-support-for-older-rails
branch
from
0f06d67 to
8c4af28
Compare
skatkov
force-pushed
the
remove-support-for-older-rails
branch
from
cca71ac to
e77b07d
Compare
skatkov
force-pushed
the
remove-support-for-older-rails
branch
from
1d6953d to
48883f7
Compare
julik
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nio4jdependency requires compilation for 6 versions of Rails. For me compilation fails, while version 7 works great.I propose we discontinue testing on Rails 6.x branches. Rails team no longer supports these versions, so we can skip those as well.