[AIA-126] Refactor chef-load to have sub-commands#20
Merged
Conversation
TODO: -handle viper config -utilize flags -random data command?
This commit is refactoring a bunch of files, it is creating two main directories, `commands/` and `lib/`. The `commands/` directory will host all the commands that chef-load will provide. The `lib/` directory is meant to be the libraries that chef-load will use to do specific tasks like generate nodes and start the continuous load of nodes, actions, reports, etc. The `lib/` directory will be able to be imported as an external library to provide load functionality to other go applications. Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
…e/AIA-126/Sub-Commands
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/AIA-126/Sub-Commands
branch
from
008f4cd to
ab2379d
Compare
added 2 commits
March 5, 2018 17:03
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
requested review from
Shadae,
jeremiahsnapp,
kmacgugan,
lancewf,
magwalk and
rmoshier
added 2 commits
March 5, 2018 17:06
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
changed the title
lancewf
reviewed
Mar 5, 2018
commands/root.go
Outdated
| func init() { | ||
| cobra.OnInitialize(initConfig) | ||
| rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.chef-load.toml)") | ||
| // TODO: Should we add data_collector_url and chef_server_url to run the tool without the config? |
Contributor
There was a problem hiding this comment.
It would be nice to add the 'data_collector_url' and 'chef_server_url' to the command line also.
lancewf
reviewed
Mar 5, 2018
| ckbk.Files, | ||
| ckbk.Libraries, | ||
| ckbk.Recipes, | ||
| ckbk.Providers, |
lancewf
reviewed
Mar 5, 2018
lib/generator.go
Outdated
| func generateRandomData(chefClient chef.Client, requests amountOfRequests) (err error) { | ||
| channels := make([]<-chan error, config.NumNodes) | ||
| func GenerateData(config *Config) error { | ||
| var amountOfRequests = make(amountOfRequests) |
Contributor
There was a problem hiding this comment.
This is a little confusing having the type amountOfRequests and the variable amountOfRequests have the same name.
lancewf
reviewed
Mar 6, 2018
|
|
||
| for { | ||
| select { | ||
| case req := <-requests: |
Contributor
There was a problem hiding this comment.
Are there two goroutine listening to the requests channel here? I see the other at generator.go. Could that be a problem?
Author
There was a problem hiding this comment.
No, but I can clean it. They are called by separate commands. 🤔 I wonder if that could be done in next PR?
Author
There was a problem hiding this comment.
This might be a hard thing but I feel weird not doing it, I guess.
lancewf
approved these changes
Mar 6, 2018
Contributor
lancewf
left a comment
lancewf
left a comment
There was a problem hiding this comment.
Nice Clean up. I have a few questions inline.
rmoshier
approved these changes
Mar 6, 2018
Contributor
rmoshier
left a comment
rmoshier
left a comment
There was a problem hiding this comment.
I suggest we update the README now that we have new subcommands.
added 3 commits
March 6, 2018 16:40
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/AIA-126/Sub-Commands
branch
from
31f8756 to
6e91c88
Compare
Author
|
Lastly, I'll modify the README as per @rmoshier comment. Maybe tomorrow morning it is 15 pass 7pm here. 😭 |
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/AIA-126/Sub-Commands
branch
2 times, most recently
from
cb8167f to
c05e86f
Compare
added 4 commits
March 7, 2018 14:39
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/AIA-126/Sub-Commands
branch
from
c05e86f to
7d79a67
Compare
Author
|
|
Author
|
Hab package uploaded to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is refactoring a bunch of files, it is creating two main
directories,
commands/andlib/.The
commands/directory will host all the commands that chef-loadwill provide.
The
lib/directory is meant to be the libraries that chef-load willuse to do specific tasks like generate nodes and start the continuous
load of nodes, actions, reports, etc.
The
lib/directory will be able to be imported as an external libraryto provide load functionality to other go applications.