fix: patch inspec-core 5.22.x/5.23.x for Parser::AST::Processor::Mixin (reconfigure crash)#4195
Merged
Merged
Conversation
👷 Deploy Preview for chef-server processing.
|
Points omnibus submodule to fix/inspec-core-parser-mixin-error branch which patches inspec-core 5.22.x/5.23.x for Parser::AST::Processor::Mixin compatibility at build time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Lincoln Baker <51833247+lbakerchef@users.noreply.github.com>
lbakerchef
force-pushed
the
fix/inspec-core-parser-mixin-error
branch
from
4a29510 to
1b9ad1c
Compare
Points to e96f0bd which includes the patch for Parser::AST::Processor::Mixin compatibility in inspec-core 5.22.x/5.23.x. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Jan Shahid Shaik <jashaik@progress.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
chef-server-ctl reconfigurecrashes on all currentmainbuilds with:This hits during "Compiling cookbooks" in the
chef-clientsubprocess spawned byrun_chef(). The gem resolver picksinspec-core-5.22.40(over the also-installed 5.24.5) because5.24.5requiresaddressable < 2.8.8which conflicts with theaddressable-2.9.0CVE pin. That broken version of inspec crashes on load.See the omnibus-config PR for full root cause analysis and the constraint triangle explanation: https://github.com/chef/chef-server-omnibus-config/pull/14
Change
Updates the
omnibussubmodule to point tochef-server-omnibus-configbranchfix/inspec-core-parser-mixin-error, which adds a build-time patch step toprivate-chef-ctl.rb.Testing
Verified in a live VM built from current
main(build 8295):Note
The submodule change targets the
fix/inspec-core-parser-mixin-errorbranch ofchef-server-omnibus-config. The omnibus-config PR should merge first (or simultaneously), then this submodule pointer should be updated to trackmainbefore merge.