[EnvironmentCookbookVersionsEndpoint] Add cookbook object cache to request logic#338
Merged
johnmccrae merged 2 commits intochef:mainfrom Sep 30, 2025
Merged
Conversation
sean-sype-simmons
approved these changes
Sep 9, 2025
jaymzh
approved these changes
Sep 16, 2025
Signed-off-by: David Crosby <dcrosby@fb.com>
64eba71 to
4bbb900
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Found this while digging into why this endpoint is slow on large numbers of cookbooks (I suspect there's still one other problem, but haven't nailed it down yet). It appears that we generate cookbook manifests at least twice (which is what that get_data call is doing under the hood), and manifest generations aren't free, as we need to hash files, etc.
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.