Add rubygems_url property to chef_client_config resource

[decoyjoe]

Adds a rubygems_url property to the chef_client_config resource to configure the same such property in client.rb

Related Issue

Fixes #12711

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[johnmccrae]

@decoyjoe I'm letting this run now but it needs some test cases. Can you add some unit and functional tests to show this doesn't break other things and how it gets handled if someone ignores the setting?

[PrajaktaPurohit]

Thank you for your PR! Looks like it needs some chefstyle fixes?

[decoyjoe]

@johnmccrae @PrajaktaPurohit I've added passing spec tests and kitchen tests, and fixed the linting failure.

[johnmccrae]

@decoyjoe Can you please replace the single-quotes in your test cases with double-quotes and re-push. (note the linting error above)

[decoyjoe]

Oops, force of habit. Fixed @johnmccrae

[lamont-granquist]

this probably isn't necessary. the default should probably be nil, either way it gets handled correctly by the code in the template, but nil is a better "unset" value.

[decoyjoe]

@lamont-granquist Is your recommendation to set default: nil or to remove the default: entirely?

[lamont-granquist]

You can omit default and it'll gain a default of nil. That'd be preferable.

[decoyjoe]

@lamont-granquist Done.

[johnmccrae]

looks good