Stop executing locale-gen on every chef run by adding -h flag

[hrak]

Signed-off-by: Hans Rakers hans@shoq.com

Description

The locale resource unnecessarily executes locale-gen on every chef run, which can be very costly on some systems.

This is caused by define_resource_requirements checking whether locale-gen is available by doing the following:

requirements.assert(:all_actions) do |a|
  # RHEL/CentOS type platforms don't have locale-gen
  a.assertion { shell_out("locale-gen") }
  a.failure_message(Chef::Exceptions::ProviderNotFound, "The locale resource requires the locale-gen tool")
end

This is causing locale-gen to be executed, regenerating all installed locales on every Chef run.

Related Issue

#12832

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[marcparadise]

See inline

[hrak]

PR updated, build failed but seems unrelated to the changes.

Would be nice to backport this to chef-17 branch too. Let me know if you want me to file a PR against the chef-17 branch.

[jaymzh]

Thanks!

[PrajaktaPurohit]

@hrak - it would be great if this can be backported to chef-17 and chef-16. Thanks!

[hrak]

@hrak - it would be great if this can be backported to chef-17 and chef-16. Thanks!

Done! See #12904 and #12905

[PrajaktaPurohit]

This looks good. Thank you for creating the backport branches! Could you please rebase the PR with the latest main? That should make the failing tests pass. We can merge it in after.

[neha-p6]

@hrak Could you rebase with latest main so that it'll fix the failures?

[hrak]

Sorry, I am currently on holiday, will do in a week! Op di 31 mei 2022 10:44 schreef neha-p6 ***@***.***>:

…

@hrak <https://github.com/hrak> Could you rebase with latest main so that it'll fix the failures? — Reply to this email directly, view it on GitHub <#12833 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAO7KE3HXJ7PC4CYRJ4ZHL3VMW7NZANCNFSM5UVKAD7Q> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[hrak]

All three PRs updated!

[hrak]

@neha-p6 the Windows builds keep failing unfortunately